Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong register decoding in execute_op16_special_data_branch #1

Open
Ko- opened this issue Jun 28, 2019 · 0 comments · May be fixed by #2
Open

Wrong register decoding in execute_op16_special_data_branch #1

Ko- opened this issue Jun 28, 2019 · 0 comments · May be fixed by #2

Comments

@Ko-
Copy link

Ko- commented Jun 28, 2019

Hi! I was trying this simulator and I noticed that I had an instruction mov r12, ... that somehow was writing to r8 according to the simulator. That shouldn't happen, of course. I checked the architecture reference manual and it seems like there's an off-by-one in the decoding of the following instructions:

  • ADD with register, encoding T2
  • CMP with register, encoding T2
  • MOV with register, encoding T1

I'll submit a PR that fixes this.
@Ko- Ko- linked a pull request Jun 28, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix wrong register decoding for some instructions Ko-/maps
1 participant
@Ko-