Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Api change] Merge ReferenceVariable and TemporaryVariable #2592

Open
montyly opened this issue Oct 17, 2024 · 0 comments
Open

[Api change] Merge ReferenceVariable and TemporaryVariable #2592

montyly opened this issue Oct 17, 2024 · 0 comments

Comments

@montyly
Copy link
Member

montyly commented Oct 17, 2024

Right now, we are using two Python classes to represent either a temporary variable or a reference. We did this because we assumed it would be easy to understand which type of variables we would manipulate at creation. However, over time, this has become more challenging. For example, when using this.something.selector, the nested member operation leads to the creation of reference variables, while what we want is a temporary variable.

I think we can evaluate merging the two classes into one, and use sub fields instead. This would allow us to easily dynamically change the type of a variable, based on the results of different analysis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@montyly and others