-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Names associated with the services are inconsistent. #10
Comments
I think it is a good idea. |
OK. I'll add a JIRA ticket for this. |
New proposed queue names (may have to put production after cular if Greg's team needs it) QUEUE_INGEST = 'cular_ingest' QUEUE_TRANSFER_S3 = 'cular_transfer_s3' QUEUE_INGEST_FIXITY_S3 = 'cular_ingest_fixity_s3' QUEUE_PERIODIC_FIXITY_S3 = 'cular_periodic_fixity_s3' QUEUE_ERROR = 'cular_error' |
For each service, there are a series of files, workers, environment variables, queues, and executables associated with them. For instance, for the service to calculate SFS fixity, we have:
SFSFixityGenerator
fixity_sfs.log
asi_sfs_fixity_*
cular_development_fixity_sfs*
and the associated ruby constantsQueues::QUEUE_FIXITY_SFS*
fixity_check_sfs.service
and associated scriptfixity_check_sfs.script
While there appears to be a preference in this case (and with the other services) to refer to it as "sfs_fixity", this is mostly internal; the externally-facing usages use a mix of
sfs_fixity_check
,fixity_sfs
,sfs_fixity
, andfixity_check_sfs
instead.This same pattern of inconsistent names exists across 5 of the 6 services, the single-word named "ingest" server excepted.
I propose that one name for each service be chosen, and the code modified to be consistent with that.
In this example, by choosing
sfs_fixity
as the name for this service, we would rename the log file tosfs_fixity.log
, the SQS queues tocular_development_sqs_fixity*
andQueues::QUEUE_SFS_FIXITY*
, and the systemd service tosfs_fixity.service
(or perhapsasi_sfs_fixity.service
so the services are grouped together insystemctl status
).The text was updated successfully, but these errors were encountered: