Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TBD: Updates for dmimgcalc stack support? #634

Open
kglotfelty opened this issue Sep 15, 2022 · 1 comment
Open

TBD: Updates for dmimgcalc stack support? #634

kglotfelty opened this issue Sep 15, 2022 · 1 comment

Comments

@kglotfelty
Copy link
Member

This is a place holder to review if there are any changes to take advantage of the arbitrary expression line length that will be available in CIAO 4.15.

Specifically we can now do

dmimgcalc @infiles none outfile [email protected]

where op.lis might look like

imgout=img1+\
img2+\
img3+\
...etc...

stacks recognize continuation lines ending in \. This allows for an arbitrary expression exceeding normal parameter interface limits.

(Well, I'd keep it under 32768 chars, but that's much more than the 1024 that the parameter interface allows).

@DougBurke
Copy link
Member

DougBurke commented Nov 14, 2022

So, a call to find . -type f -exec grep dmimgcalc {} /dev/null \; suggests we look at

  • ./ciao_contrib/_tools/fluximage.py (this just calls routines in run.py)
  • ./ciao_contrib/_tools/merging.py (this just calls routines in run.py)
  • ./ciao_contrib/_tools/run.py - see Take advantage of stack support for dmimgcalc operation parameter #682 (although could also change dmmgcalc_add)
  • ./bin/ds9_imgfit.sh
  • ./bin/blanksky_image
  • ./bin/simulate_psf
  • ./bin/ds9_imgproc_wrapper

after removal of some very-obviously not-needed-to-be-checked file. I think the ds9_* can likely be immediately excused too. edited to add likely all the bin/* scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants