Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate ele.renderedStyle() #2223

Closed
maxkfranz opened this issue Nov 22, 2018 · 1 comment
Closed

Deprecate ele.renderedStyle() #2223

maxkfranz opened this issue Nov 22, 2018 · 1 comment
Assignees
@maxkfranz
Milestone
3.3.0

Comments

@maxkfranz
Copy link
Member

Issue type

Feature request

Description of new feature

Remove ele.renderedStyle() from the docs.

Motivation for new feature

  • It returns a string value with units, so it is not ideal for getting numbers.
  • It's redundant with ele.numericStyle(). Getting a rendered value is just a matter of multiplying by zoom level.
@maxkfranz maxkfranz added this to the 3.3.0 milestone Nov 22, 2018
@maxkfranz maxkfranz self-assigned this Nov 22, 2018
maxkfranz added a commit that referenced this issue Nov 22, 2018
@maxkfranz
Remove ele.renderedStyle() from the docs
710c584 
Ref : Deprecate `ele.renderedStyle()` #2223
@maxkfranz maxkfranz mentioned this issue Nov 22, 2018
Open
18 tasks
@maxkfranz
Copy link
Member Author

Eventually for v4, the rendered value case can be removed from style.getStylePropertyValue(): #2221 #2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxkfranz maxkfranz

Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

No branches or pull requests
1 participant
@maxkfranz