Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review/Refactor the AddThis class #25

Open
doylejd opened this issue Aug 13, 2015 · 1 comment
Open

Review/Refactor the AddThis class #25

doylejd opened this issue Aug 13, 2015 · 1 comment

Comments

@doylejd
Copy link
Contributor

doylejd commented Aug 13, 2015

The AddThis class was created as a helper class in the D7 version of the module. This class has been significantly down-sized with the port to D8 since the new OO design allowed for better abstraction.

@todo:

  • Determine if the AddThis class is right to be converted into a Controller
  • Determine if pieces of the AddThis class can be abstracted out to a better home.
  • Deprecate (remove) AddThis.php if possible
@pjonckiere
Copy link

Created a pull request here: #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants