Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧩 FEATURE REQUEST: increase the limit when writing a post to 10,000 characters. #1533

Open
1 task done
sshanzel opened this issue Oct 23, 2024 · 4 comments
Open
1 task done

🧩 FEATURE REQUEST: increase the limit when writing a post to 10,000 characters. #1533

sshanzel opened this issue Oct 23, 2024 · 4 comments
Assignees
@nevilparmar11
Labels
help wanted Status: Accepted Status: Available Type: Feature

Comments

@sshanzel
Copy link
Member

Concise Description

No response

Description

There is a validation that happens on both the app and API side when it comes to the limit of characters. We should update both ends.

Reference: #1531

Solution Proposed

No response

Additional Context

No response

Code of Conduct

  • I follow the conditions of this project.
@nevilparmar11
Copy link

Hey @sshanzel, I'd like to start working on this. Thanks!

@sshanzel
Copy link
Member Author

@nevilparmar11 feel free to dig into the code! The value should be stored in a const variable that updates it across the project (both apps and daily-api must be updated).

@nevilparmar11
Copy link

nevilparmar11 commented Oct 30, 2024 •
edited
Loading

@sshanzel I'm attempting to run this locally following the Gitpod steps, but I'm encountering errors when running apps with the daily-api Dockerized version and directly from the repository, both ways. Am I missing something? Could you please assist?

I tried it with gitpod and the behavior is the same. This occurs while attempting to create a new squad/post and sometimes on some random pages.

Screenshot 2024-10-30 at 3 14 48 PM image

@Dhruv80576
Copy link

@sshanzel
I would like to work on it.

This was referenced Nov 3, 2024
Merged
Open
rebelchris added a commit to dailydotdev/daily-api that referenced this issue Nov 4, 2024
@nevilparmar11 @rebelchris
chore: update test name (#2384)
d3ce702 
Addressing dailydotdev/daily#1533

It turns out the character count update was already included in this PR:
#2374. Only the test was
missing.

Co-authored-by: Chris Bongers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nevilparmar11 nevilparmar11

Labels
help wanted Status: Accepted Status: Available Type: Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sshanzel @nevilparmar11 @Dhruv80576