Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crd-extractor.sh does not work properly on CRDs with more than one line matching kind: #287

Open
ssmall opened this issue Mar 15, 2024 · 0 comments · May be fixed by #288
Open

crd-extractor.sh does not work properly on CRDs with more than one line matching kind: #287

ssmall opened this issue Mar 15, 2024 · 0 comments · May be fixed by #288

Comments

@ssmall
Copy link

ssmall commented Mar 15, 2024

Any CRD with metadata.ownerReferences populated will break the script. E.g.

metadata:
  ownerReferences:
    - apiVersion: core.cnrm.cloud.google.com/v1beta1
      kind: ConfigConnector
      name: configconnector.core.cnrm.cloud.google.com

causes the script to incorrectly match kind: ConfigConnector as the kind for the CRD
ssmall added a commit to ssmall/CRDs-catalog that referenced this issue Mar 15, 2024
@ssmall
Use yq instead of grep to extract kind and group from CRDs
2ae7561 
This fixes datreeio#287
@ssmall ssmall linked a pull request Mar 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use yq instead of grep to extract kind and group from CRDs ssmall/CRDs-catalog
1 participant
@ssmall