Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ML-KEM-768.KeyGenDerand definition disagrees with Appendix B and C #14

Closed
FiloSottile opened this issue Feb 21, 2024 · 3 comments
Closed

Comments

@FiloSottile
Copy link

Section 4 defines ML-KEM-768.KeyGenDerand as

seed[0:32] is used for z in line 1 of algorithm 15 from [MLKEM] and seed[32:64] is used for d in line 1 of algorithm 12.

However, the implementation in Appendix B.3 does the opposite

z = seed[32:]
pk, sk2 = InnerKeyGen(seed[:32], params)

and the test vector in Appendix C passes when using seed[0:32] for d and seed[32:64] for z.

bwesterb added a commit that referenced this issue Feb 21, 2024
@bwesterb
Copy link
Collaborator

Whoops, you're right. Fixed on main.

@chris-wood
Copy link

Thanks @bwesterb. Any chance you'll cut a new version soon? I also ran into this issue.

@bwesterb
Copy link
Collaborator

Released -02.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants