-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate /lambdas/crypto/validate-signature and /lambdas/contracts/* #1518
Comments
This function can work entirely client side using the If you add it to lamb2, can you please add a |
That was 100% the idea, I added this to the new version of catalyst-client, but then talking with Frami he explained to us that this is used by every web having support for smart contract wallets for login, so we decided to keep it here. |
IS IT? how does it work? because smart contract wallets check against an ethereum node, not against the catalyst. You can read the code in |
@menduz the Authenticator receives an eth-connect http provider for this reason https://github.com/decentraland/lamb2/blob/6497a731c192f7cf9ddcb3c9f47e6e75a552cbcc/src/controllers/handlers/validate-signature.ts#L49 |
I don't see the point... In order to login from the web, you already have an There is really nothing special about that server-side provider that cannot be used from the web |
Ok, I did not know that you will always have an ethereum provider in the frontend. Here's what I would suggest: I still think we need to port this to lamb2 in order to don't delay the deprecation of lambdas, but I'm writing an ADR with all the deprecated endpoints for lambdas (which would we later submit as proposals, one per endpoint), so I'll include this there. Wdyt? |
Tasks:
validateSignature
function to @dcl/crypto library replacing/lambdas/crypto/validate-signature
endpoint functionality/lambdas/crypto/validate-signature
endpoint from Lambdas service/lambdas/contracts/servers
from Lambdas service/lambdas/contracts/denylisted-names
from Lambdas service/lambdas/contracts/pois
from Lambdas serviceThe text was updated successfully, but these errors were encountered: