Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support s3 routes #531

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: support s3 routes #531

wants to merge 1 commit into from

Conversation

2fd
Copy link
Contributor

@2fd 2fd commented Jan 4, 2023 •
edited
Loading

  • Create an ExpressJS handler
  • Connect with S3
  • Stream response from S3 to the User
  • Handle NotFound
  • Handle CORS
  • Handle OPTIONS request
  • Handle Range request
  • Test + Coverage

@2fd 2fd linked an issue Jan 4, 2023 that may be closed by this pull request
Serve S3 files using express #529
Open
6 tasks
@2fd 2fd mentioned this pull request Jan 4, 2023
Closed
13 tasks
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3839331018

  • 0 of 26 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 41.203%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/entities/Route/routes/filesystem2/s3.ts 0 26 0.0%
Totals Coverage Status
Change from base Build 3760078525: 0.7%
Covered Lines: 1203
Relevant Lines: 2660
💛 - Coveralls

@2fd 2fd self-assigned this Jan 9, 2023
@braianj braianj assigned braianj and unassigned 2fd Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@braianj braianj

Labels
stream-discoverability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serve S3 files using express
4 participants
@2fd @coveralls @braianj @xavi-dcl