From 3efaea5b0220ba6c1f42ff9a3fa365330cd7e68f Mon Sep 17 00:00:00 2001 From: Lean Mendoza Date: Mon, 5 Aug 2024 12:43:23 -0300 Subject: [PATCH] chore: remove the usage of `reserved "key"` (#211) * chore: remove the usage of `reserved "key"` * other reserved --- proto/decentraland/realm/about.proto | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/proto/decentraland/realm/about.proto b/proto/decentraland/realm/about.proto index 0667940a..76a66069 100644 --- a/proto/decentraland/realm/about.proto +++ b/proto/decentraland/realm/about.proto @@ -14,13 +14,14 @@ message AboutResponse { bool accepting_users = 7; // @deprecated This message was never used but it's still here for compatibility reasons + // The reserved keyword is not working for all the toolset we have, so in the meanwhile it keeps commented message MinimapConfiguration { reserved 1; - reserved "enabled"; + // reserved "enabled"; reserved 2; - reserved "data_image"; + // reserved "data_image"; reserved 3; - reserved "estate_image"; + // reserved "estate_image"; } message MapConfiguration { @@ -84,8 +85,12 @@ message AboutResponse { uint32 network_id = 2; repeated string global_scenes_urn = 3; repeated string scenes_urn = 4; + + // The name "minimap" can't be used in this message + // The reserved keyword is not working for all the toolset we have, so in the meanwhile it keeps commented reserved 5; - reserved "minimap"; + // reserved "minimap"; + optional SkyboxConfiguration skybox = 6; // A content server to be used to load the parcels around the user. Uses the POST /entities/active endpoint