Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA] Backpack Equip/Unequip Exception & Profile Save Failure #2382

Open
Ludmilafantaniella opened this issue Oct 9, 2024 · 2 comments · May be fixed by #2435
Open

[QA] Backpack Equip/Unequip Exception & Profile Save Failure #2382

Ludmilafantaniella opened this issue Oct 9, 2024 · 2 comments · May be fixed by #2435
Assignees
@davidejensen
Labels
2-medium Important issues we must fix, but not as important as high! bug Something isn't working
Milestone
Beta Release

Comments

@Ludmilafantaniella
Copy link

Explorer Alpha build versions:

  • v0.33.0

Issue Description:

When equipping or unequipping a wearable item in the backpack, if the backpack is closed before the wearable appears in the character preview, an exception is thrown. This prevents the changes from being saved to the user's profile. Initially, this issue was reproducible, but it seems to have become intermittent.

Additionally, writing to the profile fails without a retry mechanism or feedback to the player. This results in players being unaware that their changes to the profile have not been saved.

STR:

  1. Open the backpack.
  2. Equip or unequip a wearable item.
  3. Close the backpack before the wearable appears in the character preview.
  4. Observe the thrown exception and the inability to save changes.

Expected Behavior:

  • The wearable should appear in the character preview and the changes should save to the profile without errors.
  • Players should receive a notification or message if saving to the profile fails.

Actual Behavior:

  • An exception is thrown when the backpack is closed prematurely.
  • Changes to the profile do not save, and players are not notified of the failure.
2024-10-09.15-03-33.mp4

Fran Backpack Exception Issue.txt
@Ludmilafantaniella Ludmilafantaniella added bug Something isn't working 1-high Very important but not critical or game breaking new Issues to triage labels Oct 9, 2024
@m3taphysics m3taphysics removed the new Issues to triage label Oct 14, 2024
@aixaCode aixaCode added this to the Beta Release milestone Oct 14, 2024
@davidejensen
Copy link
Member

I was investigating this, the actual problem is more specific, the first time it's working fine, by waiting a moment it would show the updated avatar and would save the changes, the problem is the actual second request, that it's performed very fast close to the first one.
It is failing because the backend is still processing the first request and we cannot do much about it, this doesn't break the flow as the next time you change something it will work fine, hence I would close this as it's not controllable on our side.
What do you think @m3taphysics ?

@m3taphysics m3taphysics added 2-medium Important issues we must fix, but not as important as high! and removed 1-high Very important but not critical or game breaking labels Oct 14, 2024
@m3taphysics
Copy link
Collaborator

Does not break flow downgraded to a medium, we are discussing a retry mechanism for when the profile cannot be deployed and it is because of an on-going deployment.

@davidejensen davidejensen linked a pull request Oct 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidejensen davidejensen

Labels
2-medium Important issues we must fix, but not as important as high! bug Something isn't working
Projects
None yet
Milestone
Beta Release
Development

Successfully merging a pull request may close this issue.

fix: added retry await for profile deployment requests decentraland/unity-explorer
4 participants
@m3taphysics @davidejensen @aixaCode @Ludmilafantaniella