Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract e2e test vector set and/or profile from verite and tbd implementations? #426

Open
bumblefudge opened this issue Mar 23, 2023 · 10 comments
Assignees
Labels
help wanted Extra attention is needed testing related to some testing.
Milestone

Comments

@bumblefudge
Copy link
Collaborator

bumblefudge commented Mar 23, 2023

Initial Thoughts:

  • test harness? jest type harness versus docker-based? is what's in there now JUST for JSONSchema?
  • could pair with, e.g., a VC-JWT and did-method-set profile for people to run locally/internally and self-attest
  • start with e2e/reasonable coverage, do full conformance in a second pass?
  • what if there was a pathed, CCG DID:WEB... for this repo (and in spec-up)? with the private key checked into /tests/ ? and a holder private key as well for metamask or did:ion?

Current State:

  • incremeetal approach: build up vectors towards e2e coverage, then scripts, then suite/harness
@bumblefudge bumblefudge transferred this issue from decentralized-identity/credential-manifest Mar 23, 2023
@bumblefudge
Copy link
Collaborator Author

(will check in at next week's meeting on normative statements and neg vectors)

@decentralgabe
Copy link
Member

jest is fine, since we'll just be plugging in json. I'm not a js/ts guy though so can't commit to doing the impl but I can commit to generating the vectors

@bumblefudge
Copy link
Collaborator Author

Discuss next week?

@andorsk
Copy link
Contributor

andorsk commented May 4, 2023

Discussed on DIF:

  1. Focus on building the test vectors out first ( can do )
  2. Second, let's build out the test harness. ( challenged with resources. need to find a way to get this through with the limited bandwidth everyone has)

@andorsk andorsk added the testing related to some testing. label May 4, 2023
@bumblefudge
Copy link
Collaborator Author

bumblefudge commented Jun 15, 2023

update on today's call - Kim will check in a few vectors later in the summer to get the ball rolling but others shouldn't wait for her if they have unit tests they can check in

@bumblefudge bumblefudge added the help wanted Extra attention is needed label Jun 15, 2023
@kimdhamilton
Copy link
Collaborator

kimdhamilton commented Jul 5, 2023

I started on this. Key references:

The README.md in the pe-tests repo has a description of the intended structure, approach, and issues to discuss. I'd like to discuss these with you folks before proceeding further.

I've started roughly mapping the tests to @bumblefudge's spreadsheet (thanks again Juan!) and also have flagged some spec language issues, as we expected would happen.

We could consider moving another of my WIP repos to DIF, which was intended as a basic sample implementation of PE and CM, plus serve as a useful library for node/js. It would just take a little more work for me to push along and use this as a sample implementation of the pe-test suite. Just mentioning in case we are interested.

@csuwildcat @decentralgabe @brentzundel @andorsk @bumblefudge

@bumblefudge
Copy link
Collaborator Author

Niels pointed out there is an OpenAPI def for v1 and for v2 already on their repo:
https://github.com/Sphereon-Opensource/pex-openapi
to generate APIs per language...

@bumblefudge
Copy link
Collaborator Author

bumblefudge commented Jul 13, 2023

Also, as Niels pointed out on the call, https://github.com/kimdhamilton/presex-lib is currently private, @kimdhamilton ! Feel free to gather additional requirements from, link to, and then close the other test-suite issues while you're at it :D

@bumblefudge
Copy link
Collaborator Author

Testing artefacts moved into a DIF repo and editors here are now CODEOWNERS over there, so feel free to PR against it if you find bugs or nits!

@kimdhamilton
Copy link
Collaborator

Also, as Niels pointed out on the call, https://github.com/kimdhamilton/presex-lib is currently private, @kimdhamilton ! Feel free to gather additional requirements from, link to, and then close the other test-suite issues while you're at it :D

Thanks for the reminder @bumblefudge -- I switched it to public

@brentzundel brentzundel added this to the future milestone Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed testing related to some testing.
Projects
None yet
Development

No branches or pull requests

5 participants