Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example diversity: include a few hardcoded single-value or enum examples in filters #449

Open
bumblefudge opened this issue Oct 12, 2023 · 0 comments
Open

Example diversity: include a few hardcoded single-value or enum examples in filters #449

bumblefudge opened this issue Oct 12, 2023 · 0 comments
Assignees
@bumblefudge
Labels
editorial Non-normative and non-breaking string changes

Comments

@bumblefudge
Copy link
Collaborator

Niels pointed out (just before a PR was merged and the comment disappeared) that we have many regexp patterns in the examples, in situations where a hard-coded value or an allowlist/enum would be more realistic. A non-normative (and thus not timeline-blocking) tweak would be to go in a swap out a regexp here and there so that people that read examples first see both kinds of filters represented?
@bumblefudge bumblefudge added the editorial Non-normative and non-breaking string changes label Oct 12, 2023
@bumblefudge bumblefudge self-assigned this Oct 12, 2023
@bumblefudge bumblefudge changed the title Example diversity: Example diversity: include a few hardcoded single-value or enum examples in filters Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bumblefudge bumblefudge

Labels
editorial Non-normative and non-breaking string changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bumblefudge