Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSONSchema issue for 2.1: we are using later syntax? #455

Open
kimdhamilton opened this issue Nov 2, 2023 · 5 comments
Open

JSONSchema issue for 2.1: we are using later syntax? #455

kimdhamilton opened this issue Nov 2, 2023 · 5 comments
Labels
editorial Non-normative and non-breaking string changes further clarification needed Need further input to make progress last-call About to close if no update
Milestone

Comments

@kimdhamilton
Copy link
Collaborator

Some discussion out of IIW: concerns about JSON schema are related to test vectors used to test conformance. We use a more recent syntax that is perhaps difficult for some peoples' toolsets. Syntax might be $ref; need to confirm

If correct, this should be a simple fix for 2.1

@kimdhamilton kimdhamilton added editorial Non-normative and non-breaking string changes further clarification needed Need further input to make progress labels Nov 2, 2023
@kimdhamilton kimdhamilton added this to the v2.1 milestone Nov 2, 2023
@kimdhamilton
Copy link
Collaborator Author

kimdhamilton commented Dec 21, 2023

@rado0x54 @andorsk @csuwildcat confirm this is blocking for 2.1 and get owner if so

@dif-admin
Copy link
Member

possibly dropped? Could be referring to schemas in repo

@kimdhamilton
Copy link
Collaborator Author

Maybe this is the concern: https://json-schema.org/understanding-json-schema/structuring#dollarref

In Draft 4-7, $ref behaves a little differently. When an object contains a $ref property, the object is considered a reference, not a schema. Therefore, any other properties you put in that object will not be treated as JSON Schema keywords and will be ignored by the validator. $ref can only be used where a schema is expected.

@kimdhamilton
Copy link
Collaborator Author

kimdhamilton commented Feb 22, 2024

here is an example this could be referring to. In 4-7, since $ref is in path_nested, type would be ignored by a validator.

Note the above example is recursive. But this is only a problem with a $ref referring to another $ref (source: https://json-schema.org/understanding-json-schema/structuring#recursion)

@kimdhamilton
Copy link
Collaborator Author

After discussion on Feb 29, 2024, we realized we can't reconstruct the concern coming out of IIW. Please provide context on what the concern with $ref was by March 15; otherwise we will close

@kimdhamilton kimdhamilton added the last-call About to close if no update label Mar 5, 2024
@dif-admin dif-admin reopened this Mar 21, 2024
@dif-admin dif-admin modified the milestones: v2.1, future Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Non-normative and non-breaking string changes further clarification needed Need further input to make progress last-call About to close if no update
Projects
None yet
Development

No branches or pull requests

2 participants