-
Notifications
You must be signed in to change notification settings - Fork 16
Support Deno canary channel #76
Comments
It seems that deno-canary is redundant We can check whether it is a hash from deno-version steps:
- uses: denolib/setup-deno@v3
with:
deno-version: 973af61d8bb03c1709f61e456581d58386ed4952
- deno-canary: true |
If |
you can also do: set edit: typo |
I would prefer that actually.
|
I personally prefer not to bring any BREAKING CHANGES. I want users to always use v2. Especially this PR(actions/starter-workflows#604) have been merged. steps:
- uses: denolib/setup-deno@v2
with:
deno-version: canary
# canary = nightly
# deno-version: nightly
# deno-version: <HASH> Just need to do two things
|
I don't think keeping the version at v2 would help with actions/starter-workflows#604 as it is locked to a commit hash rather than a tag. I'd suggest go forward with the breaking change and even phase out nightly altogether as it was a temporary solution until there was an official solution, which there is now - canaries. My nightly solution is prone to breaking and has some builds missing because of refactors in Deno's code that I didn't catch in time. the reason imo v3 should be: # Latest version
- uses: denolib/setup-deno@v3
# Latest version in a range
- uses: denolib/setup-deno@v3
with:
version: 1.5 # (resolve to 1.5.4)
# Locked version
- uses: denolib/setup-deno@v3
with:
version: 1.5.4
# Latest canary
- uses: denolib/setup-deno@v3
with:
version: canary
# Locked canary
- uses: denolib/setup-deno@v3
with:
version: 5f05e1783e9f08d1be4b71f2099601458da78dcd
|
I agree with Axetroy's view that nightly will be an alias for canary. In addition, we also need to update the version of setup-deno in starter-workflows to prevent the unofficial nightly mirror breaking |
starter-workflows is not accepting changes and won't for a while. |
From #47 (comment)
The text was updated successfully, but these errors were encountered: