Skip to content
This repository has been archived by the owner on Oct 25, 2023. It is now read-only.

Support Deno canary channel #76

Open
zhmushan opened this issue Dec 2, 2020 · 8 comments
Open

Support Deno canary channel #76

zhmushan opened this issue Dec 2, 2020 · 8 comments

Comments

@zhmushan
Copy link
Member

zhmushan commented Dec 2, 2020

From #47 (comment)

steps:
  - uses: denolib/setup-deno@v3
    with:
      deno-version: 973af61d8bb03c1709f61e456581d58386ed4952
      deno-canary: true
@axetroy
Copy link
Member

axetroy commented Dec 2, 2020

It seems that deno-canary is redundant

We can check whether it is a hash from deno-version

steps:
  - uses: denolib/setup-deno@v3
    with:
      deno-version: 973af61d8bb03c1709f61e456581d58386ed4952
-      deno-canary: true

@zhmushan
Copy link
Member Author

zhmushan commented Dec 2, 2020

If deno-canary is set, users can omit deno-version to get the latest canary release

@maximousblk
Copy link

maximousblk commented Dec 3, 2020

you can also do: set deno-version to canary to get latest canary. similar to nightly.

edit: typo

@lucacasonato
Copy link
Contributor

I would prefer that actually.

steps:
  - uses: denolib/setup-deno@v3
    with:
      deno-version: canary
steps:
  - uses: denolib/setup-deno@v3
    with:
      deno-version: 973af61d8bb03c1709f61e456581d58386ed4952

@axetroy
Copy link
Member

axetroy commented Dec 10, 2020

I personally prefer not to bring any BREAKING CHANGES.

I want users to always use v2.

Especially this PR(actions/starter-workflows#604) have been merged.

steps:
  - uses: denolib/setup-deno@v2
    with:
      deno-version: canary
      # canary = nightly
      # deno-version: nightly
      # deno-version: <HASH>

Just need to do two things

  1. Support HASH
  2. Use nightly as an alias for canary, and it is no longer recommended in the document, and output a warning when
    using.

@maximousblk
Copy link

maximousblk commented Dec 10, 2020

I don't think keeping the version at v2 would help with actions/starter-workflows#604 as it is locked to a commit hash rather than a tag.

I'd suggest go forward with the breaking change and even phase out nightly altogether as it was a temporary solution until there was an official solution, which there is now - canaries. My nightly solution is prone to breaking and has some builds missing because of refactors in Deno's code that I didn't catch in time. the reason setup-deno didn't break was that I had a latest tag which would always have the latest available build even if the workflow breaks.

imo v3 should be:

# Latest version
- uses: denolib/setup-deno@v3

# Latest version in a range
- uses: denolib/setup-deno@v3
  with:
    version: 1.5 # (resolve to 1.5.4)

# Locked version
- uses: denolib/setup-deno@v3
  with:
    version: 1.5.4

# Latest canary
- uses: denolib/setup-deno@v3
  with:
    version: canary

# Locked canary
- uses: denolib/setup-deno@v3
  with:
    version: 5f05e1783e9f08d1be4b71f2099601458da78dcd

@zhmushan
Copy link
Member Author

I agree with Axetroy's view that nightly will be an alias for canary. In addition, we also need to update the version of setup-deno in starter-workflows to prevent the unofficial nightly mirror breaking

@maximousblk
Copy link

maximousblk commented Dec 10, 2020

starter-workflows is not accepting changes and won't for a while.

Ref: actions/starter-workflows#631

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants