Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

putting the change behind the DET_DEBUG flag seems reasonable but I'll leave it up to you if asking users to reproduce the issue with the debug flag isn't or is not feasible/good. #10117

Open
Eotia-was-taken opened this issue Oct 24, 2024 · 1 comment

Comments

@Eotia-was-taken
Copy link

          putting the change behind the DET_DEBUG flag seems reasonable but I'll leave it up to you if asking users to reproduce the issue with the debug flag isn't or is not feasible/good.

Originally posted by @hamidzr in #5967 (review)

Yes, please do this. It feels really bad to have possible environment variables (set in startup-hook.sh for example) exposed by default in the log.
Something like:

export MYSTERIOUS_API_KEY=$(cat /foobar/.secret)

should really not be exposed in the log by default.

@Eotia-was-taken
Copy link
Author

Workaround if you are struggling with the same issue:

set +x
export MYSTERIOUS_API_KEY=$(cat /foobar/.secret)
set -x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant