Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styled-components as peerDependency #2

Open
devboell opened this issue Apr 15, 2018 · 5 comments
Open

styled-components as peerDependency #2

devboell opened this issue Apr 15, 2018 · 5 comments
Assignees

Comments

@devboell
Copy link
Owner

There's an issue with having two instances of styled-components running at the same time. For now I put it in webpack externals, but I'd rather not force a user to install styled-components if they are not using it themselves.

@devboell devboell self-assigned this Apr 17, 2018
@alexkilla
Copy link

Hi @devboell great to get to know your project I'm trying to use it but I got the error you describe above.

$ yarn add react-fretboard
yarn add v0.27.5
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning "[email protected]" has unmet peer dependency "styled-components@^3.2.3".
[4/4] Building fresh packages...
success Saved 1 new dependency.
└─ [email protected]
Done in 4.62s.

Is there a workaround for this? pretty new to react and new webpack setup thing.

@devboell
Copy link
Owner Author

Hi @alexkilla, it should work when you install styled-components in your own project. Have you tried that?

@ccorcos
Copy link

ccorcos commented Oct 31, 2020

Not working for me with a simple example: https://codesandbox.io/s/nervous-albattani-1w35z?file=/src/App.js:113-194

@devboell
Copy link
Owner Author

devboell commented Nov 1, 2020

@ccorcos I don't know what is going on here, seems codesandbox is looking for styled-components in the wrong place.

@jordanforbes
Copy link

Hi @devboell this library looks fantastic and would be great for what I'm working on, but I'm running into the same exact issue as everyone else. styled-components is breaking this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants