-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LangVersion latest and using 11.0 constants #311
LangVersion latest and using 11.0 constants #311
Comments
This is quite weird, since the generator explicitly checks for lang version 11+: https://github.com/devlooped/ThisAssembly/blob/main/src/ThisAssembly.Constants/ConstantsGenerator.cs#L50-L51, and the only change from 3.3.0 > 3.3.1 was removing SponsorLink v1.... 😕 |
FOUND IT: https://github.com/dotnet/roslyn/blob/main/src/Compilers/CSharp/Portable/LanguageVersion.cs#L216 It should be 1100+ |
LanguageVersion for C# 11 is (int)1100 See https://github.com/dotnet/roslyn/blob/main/src/Compilers/CSharp/Portable/LanguageVersion.cs#L216 Fixes devlooped/GitInfo#311
LanguageVersion for C# 11 is (int)1100 See https://github.com/dotnet/roslyn/blob/main/src/Compilers/CSharp/Portable/LanguageVersion.cs#L216 Fixes devlooped/GitInfo#311
Shipping in v3.3.2 |
If you enjoyed the quick turnaround for the fix, please consider sponsoring at https://github.com/sponsors/devlooped/ 💜 |
Describe the Bug
First, this is a great project.
I am working on an project with net6.0. I updated to GitInfo 3.3.1 and get an bunch of errors:
Steps to Reproduce
In csprof or Directory.Build.props set:
Sample generated class
Expected Behavior
Class should not contain C# 11 syntex
Version Info
GitInfo 3.3.1
Additional Info
Version 3.3.0 worked fine
The text was updated successfully, but these errors were encountered: