Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RBP logos (dynamic images) #134

Open
eboileau opened this issue Aug 9, 2024 · 1 comment
Open

Add RBP logos (dynamic images) #134

eboileau opened this issue Aug 9, 2024 · 1 comment
Assignees
Labels
priority:low Low priority issue status:on-hold Temporarily not being dealt with or pursued
Milestone

Comments

@eboileau
Copy link
Collaborator

eboileau commented Aug 9, 2024

Aims/objectives.

If we don't want to use the public or assets folder strategy, adding images is not as simple as I thought...

A clear and concise description of todo items.

it would be nice to add logo images, but it's not a priority.

@eboileau eboileau added this to the Monday sprint milestone Aug 9, 2024
@eboileau eboileau self-assigned this Aug 9, 2024
@eboileau eboileau added priority:low Low priority issue status:on-hold Temporarily not being dealt with or pursued labels Aug 12, 2024
@eboileau
Copy link
Collaborator Author

Ok, public or assets folder strategy is the way to go if we want to add images. For development, this is straightforward, but we need to make sure they are not version controlled; for production we have to integrate it e.g. into the app Dockerfile, by copying files from some location on app01.

We might face a problem of image quality (png), though.

I believe this can wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low Low priority issue status:on-hold Temporarily not being dealt with or pursued
Projects
None yet
Development

No branches or pull requests

1 participant