Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How does the importer handles extra header lines? #142

Open
eboileau opened this issue Aug 20, 2024 · 0 comments
Open

How does the importer handles extra header lines? #142

eboileau opened this issue Aug 20, 2024 · 0 comments
Assignees
Labels
needs:testing Add tests type:bug Something isn't working

Comments

@eboileau
Copy link
Collaborator

eboileau commented Aug 20, 2024

A clear and concise description of what the bug is.

The question is, in fact, how it handles valid extra header lines?

By error, a file was uploaded which had twice the same header, except for the organism (or assembly). The "second" header was wrong, and upload failed, as if information from the second header was also used. In this case, I would have expected that all comment lines after the "true" header are ignored.

This is an unlikely scenario, but I believe we should go though the importer tests to make sure we do cover general variations on header format and length. In particular, we need to think if we should (and how to) handle the newly added tag #internal_source, which is not meant to be part of the EUF specifications.

@eboileau eboileau added the type:bug Something isn't working label Aug 20, 2024
@eboileau eboileau self-assigned this Aug 20, 2024
@eboileau eboileau added the needs:testing Add tests label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:testing Add tests type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant