Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why bb8-redis can't support redis features? #146

Open
Cheban1996 opened this issue Dec 26, 2022 · 3 comments · May be fixed by #183
Open

Why bb8-redis can't support redis features? #146

Cheban1996 opened this issue Dec 26, 2022 · 3 comments · May be fixed by #183

Comments

@Cheban1996
Copy link

I want use redis script but for bb8-redis features is disable default-features = false
How i can enabled them?

@djc
Copy link
Owner

djc commented Dec 26, 2022

By depending on redis directly in your downstream crate and enabling the features there. If you want I'd welcome a PR that adds forwarding features to bb8-redis.

@edmondwinston
Copy link

@djc

I'm using bb8 and would like to fix this, but I can really use a hand.

  1. What does it mean by depending on redis directly on your downstream crate? Does it mean to have both bb8 and redis-rs? If so, could you please elaborate more on how to connect them? I tried but the error is too much for me.
  2. I understand the term forwarding features, but still have no idea how to implement after browsing round. Best I could find is having local patches, which is also what I have been doing, so could you please provide some links/guide?

Thank you!

@djc
Copy link
Owner

djc commented Dec 11, 2023

  1. Yes, you'd have dependencies for both. Have to make sure they're using the same version, though.
  2. I meant sending a PR that adds lines like "foo" = ["redis/foo"] to the bb8-redis Cargo.toml.

@edmondwinston edmondwinston linked a pull request Dec 22, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants