Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor icons system to use materialdesignicons.com #7

Open
t0mg opened this issue Mar 23, 2017 · 2 comments
Open

Refactor icons system to use materialdesignicons.com #7

t0mg opened this issue Mar 23, 2017 · 2 comments
Assignees

Comments

@t0mg
Copy link
Collaborator

t0mg commented Mar 23, 2017

From @t0mg on February 7, 2017 23:46

Copied from original issue: t0mg/reacticz#65

@t0mg
Copy link
Collaborator Author

t0mg commented Mar 23, 2017

From @gerard33 on February 8, 2017 12:3

Did a small test using some icons from materialdesignicons.com with the svg method you built in the html and that is looking good I think. What do you think of it?

If this is the way forward let me know if you need some help with changing the icons.

img_0292

<symbol id="hum" viewBox="0 0 24 24"> <path d="M12,3.25C12,3.25 6,10 6,14C6,17.32 8.69,20 12,20A6,6 0 0,0 18,14C18,10 12,3.25 12,3.25M14.47,9.97L15.53,11.03L9.53,17.03L8.47,15.97M9.75,10A1.25,1.25 0 0,1 11,11.25A1.25,1.25 0 0,1 9.75,12.5A1.25,1.25 0 0,1 8.5,11.25A1.25,1.25 0 0,1 9.75,10M14.25,14.5A1.25,1.25 0 0,1 15.5,15.75A1.25,1.25 0 0,1 14.25,17A1.25,1.25 0 0,1 13,15.75A1.25,1.25 0 0,1 14.25,14.5Z" /> </symbol> <symbol id="temp" viewBox="0 0 24 24"> <path d="M17,3H21V5H17V3M17,7H21V9H17V7M17,11H21V13H17.75L17,12.1V11M21,15V17H19C19,16.31 18.9,15.63 18.71,15H21M17,17A5,5 0 0,1 12,22A5,5 0 0,1 7,17C7,15.36 7.79,13.91 9,13V5A3,3 0 0,1 12,2A3,3 0 0,1 15,5V13C16.21,13.91 17,15.36 17,17M11,8V14.17C9.83,14.58 9,15.69 9,17A3,3 0 0,0 12,20A3,3 0 0,0 15,17C15,15.69 14.17,14.58 13,14.17V8H11M7,3V5H3V3H7M7,7V9H3V7H7M7,11V12.1L6.25,13H3V11H7M3,15H5.29C5.1,15.63 5,16.31 5,17H3V15Z" /> </symbol>

@t0mg t0mg self-assigned this Mar 23, 2017
@t0mg
Copy link
Collaborator Author

t0mg commented Mar 23, 2017

Yes this svg method is nice because it keeps the build size to the strict minimum. But I'd like to explore other solutions because adding a new icon this way is rather tedious and error-prone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant