NullReferenceException from CSharpPreferGenericOverloadsAnalyzer in .NET 9 RC1 #7421
Comments
|
Thanks for reporting this issue, I've reproduced the problem and got the following stack trace: You can change the line below as workaround to no longer get a NPE during build. The build then completes without errors. - Request.Relationship?.LeftType.ClrType.Should().Be(typeof(TLeft));
+ Request.Relationship?.LeftType.ClrType.Should().Be<TLeft>();As for why a NPE exception is thrown is not completely clear to me. It happens during speculative binding of the new generic invocation: I can reproduce the NPE with the following test case: [Fact, WorkItem(7421, "https://github.com/dotnet/roslyn-analyzers/issues/7421")]
public async Task Issue7421_OffersFixer_CS()
{
string source = """
#nullable enable
class A
{
public B? B { get; set; }
public C? C { get; set; }
}
class B
{
public C C { get; set; } = new();
}
class C
{
public void M(System.Type type) { }
public void M<T>() { }
void Test()
{
new A().B?.C.M(typeof(C));
}
}
""";
var test = new VerifyCS.Test
{
TestCode = source,
FixedCode = source,
LanguageVersion = CodeAnalysis.CSharp.LanguageVersion.CSharp9
};
await test.RunAsync();
}This seems to have something to do with the use of a null-conditional operator and not directly calling the method on the result. In other words, if I change the line to either // Call method 'M' directly after '?.'
new A().C?.M(typeof(C));or // Do not use '?.'
new A().B.C.M(typeof(C));I no longer get a crash.
Based on dotnet/roslyn#72076 (comment), this could be the same problem as dotnet/roslyn#72076. |
|
@mpidash Thanks for investigating. I can confirm the suggested change fixes the NRE during build. |
|
On a side note, I'm getting the gold bar with crashing analyzers all the time in VS 17.12.0 Preview 2.1. Both during personal development and at work in a very different codebase. Hopefully, telemetry is being collected so this can be fixed before RTM.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Analyzer
Diagnostic ID: CA2263:
Prefer generic overload when type is knownDescribe the bug
After updating our codebase to .NET 9 RC1, the following warning is logged during build. This doesn't show when building against .NET 8.
I'm not aware of an easy way to determine which line of code this originates from. This can be reproduced by cloning the JsonApiDotNetCore repository and building the
dotnet9-previewbranch, after commenting out the following in.editorconfig:I've tried installing the latest prerelease version, which doesn't help:
The text was updated successfully, but these errors were encountered: