Update field references #7430
Merged
Update field references #7430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7430 +/- ##
==========================================
- Coverage 96.50% 96.49% -0.01%
==========================================
Files 1448 1448
Lines 346766 346760 -6
Branches 11399 11399
==========================================
- Hits 334640 334618 -22
- Misses 9238 9253 +15
- Partials 2888 2889 +1 |
|
@dotnet/roslyn-analysis, please review, thanks. |
stephentoub
reviewed
Oct 3, 2024
| @@ -186,7 +186,7 @@ internal bool ShouldBeTrackedForAnalysis(bool hasCompletePointsToAnalysisResult) | |||
|
|
|||
| public bool HasConstantValue => Symbol switch | |||
| { | |||
| IFieldSymbol field => field.HasConstantValue, | |||
| IFieldSymbol fieldSymbol => fieldSymbol.HasConstantValue, | |||
| ILocalSymbol local => local.HasConstantValue, | |||
There was a problem hiding this comment.
For consistency, could you also rename local to localSymbol?
stephentoub
approved these changes
Oct 3, 2024
333fred
approved these changes
Oct 3, 2024
|
@cston - we need this fix in 9.0 - presumably a backport PR will be created. |
|
/backport to release/9.0.1xx |
|
Started backporting to release/9.0.1xx: https://github.com/dotnet/roslyn-analyzers/actions/runs/11170944157 |
|
Should we create a release/9.0.2xx branch and backport this there instead? Asking because I see we already have such branch in dotnet/sdk: https://github.com/dotnet/sdk/tree/release/9.0.2xx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename or qualify
fieldreferences in property accessors to avoid conflict withfieldkeyword in C# compiler preview.Fixes #7429