Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[circle] pipeline should not require workflow #123

Open
jimsheldon opened this issue Jun 29, 2023 · 2 comments
Open

[circle] pipeline should not require workflow #123

jimsheldon opened this issue Jun 29, 2023 · 2 comments
Labels
bug Something isn't working circle Circle CI conversion targer

Comments

@jimsheldon
Copy link
Contributor

This is a valid circle pipeline:

version: 2.1
orbs:
  browser-tools: circleci/[email protected]
jobs:
  build:
    docker:
      - image: cimg/node:16.19.1-browsers

    working_directory: ~/repo

    steps:
      - browser-tools/install-chrome
      - checkout
      - run: npm ci
      - run: |
          node bin/transifex/restructure.js
          git diff --exit-code -- transifex/strings_en.json
      - run: npm run lint
      - run: npm run test

Conversion fails with no workflows defined.

Our conversion shouldn't require a workflow.

@jimsheldon jimsheldon added bug Something isn't working circle Circle CI conversion targer labels Jun 29, 2023
@bradrydzewski
Copy link
Member

bradrydzewski commented Jun 29, 2023

How does Circle behave when there are 2+ jobs, but no workflows?

The reason I ask is that in yaml, the order of map keys are not guaranteed. This has me wondering how Circle handles a scenario where multiple jobs are defined given the lack of guaranteed job ordering (at least per the yaml spec). For example, given the below yaml with build and test jobs, the yaml spec makes no guarantees that ordering is preserved.

jobs:
  build:
  test:
``

@jimsheldon
Copy link
Contributor Author

I just tried with this pipeline

version: 2.1

jobs:
  build:
    docker:
      - image: cimg/base:2023.03
    steps:
      - checkout
      - run:
          name: build
          command: echo "this is the build job"
  test:
    docker:
      - image: cimg/base:2023.03
    steps:
      - checkout
      - run:
          name: test
          command: echo "this is the test job"

This is the result https://app.circleci.com/pipelines/github/jimsheldon/sandbox/9/workflows/e4870d97-9c21-47af-8211-c2a83844b889/jobs/10

It appears only the first job ran.

I opened this issue after trying to convert this pipeline https://github.com/getodk/central-frontend/blob/master/.circleci/config.yml, which only has one job.

Perhaps we should support converting the first job when there are no workflows?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working circle Circle CI conversion targer
Projects
None yet
Development

No branches or pull requests

2 participants