Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type conversion errors not thrown with duckdb-wasm #1662

Closed
ilyabo opened this issue Mar 10, 2024 · 2 comments
Closed

Type conversion errors not thrown with duckdb-wasm #1662

ilyabo opened this issue Mar 10, 2024 · 2 comments

Comments

@ilyabo
Copy link

ilyabo commented Mar 10, 2024

What happens?

At least some queries with conversion errors don't throw, but return an empty result set, when run via AsyncDuckDBConnection.query(). For example, this query:

select '24:01:01'::time 

throws Conversion Error: time field value out of range in the shell, but just returns 0 rows without any errors when using conn.query() which is misleading.

To Reproduce

Run this example:

https://gist.githubusercontent.com/ilyabo/4c5a6421c55fb9fdca09c04081b21d75/raw/3025c5db72127573b2f643dbd6b663fa832232dc/index.html

It doesn't throw an error, but outputs the result:

Browser/Environment:

Chrome 122

Device:

Macbook Pro M1

DuckDB-Wasm Version:

1.28.0, 1.28.1-dev106.0

DuckDB-Wasm Deployment:

custom app

Full Name:

Ilya Boyandin

Affiliation:

GeoVisually

@jonathanswenson
Copy link

maybe similar to #1329 / #1347

@carlopi
Copy link
Collaborator

carlopi commented Jun 17, 2024

I just tried to reproduce, it seems to be properly solved by the current dev version, https://www.npmjs.com/package/@duckdb/duckdb-wasm/v/1.28.1-dev223.0.

Thanks a lot for raising this, it can now be closed.

@carlopi carlopi closed this as completed Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants