-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert index scan functionality #183
Comments
Yes, imo all index functionality and code should be revisited again probably when i return back to finalize #71 feature. |
It was working in the past iirc, also at minimum it shouldn't crash the server, but throw a clear error. But preferably it would fall back to sequence scan. |
As discussed over chat. Our current Postgres index scan logic is incorrect. For 0.1.0 we've decided to revert the feature completely and only support sequential scans on postgres data from duckdb. It's definitely a feature we want, but we're not going to let it block version 0.1.0. We'll probably redesign it for version 0.2.0. |
Reverting index scan feature as explaind in #183. Removed include directives that are not needed.
Reverting index scan feature as explained in #183. Removed include directives that are not needed.
Reverting index scan feature as explained in #183.
Reverting index scan feature as explained in #183.
Reverting index scan feature as explained in #183.
Reverting index scan feature as explained in #183.
@Tishj mentioned in #97 that we don't have tests for index scans. So I tried adding some basic tests for this. And as it turns out index scans are very much (and possibly completely) broken. This trivial example crashes the server for me:
The text was updated successfully, but these errors were encountered: