Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert index scan functionality #183

Closed
JelteF opened this issue Sep 17, 2024 · 3 comments · Fixed by #247
Closed

Revert index scan functionality #183

JelteF opened this issue Sep 17, 2024 · 3 comments · Fixed by #247
Assignees
Labels
bug Something isn't working

Comments

@JelteF
Copy link
Collaborator

JelteF commented Sep 17, 2024

@Tishj mentioned in #97 that we don't have tests for index scans. So I tried adding some basic tests for this. And as it turns out index scans are very much (and possibly completely) broken. This trivial example crashes the server for me:

CREATE TABLE test_table (id int primary key, name text);
SELECT * FROM test_table where id = 1;
@JelteF JelteF added the bug Something isn't working label Sep 17, 2024
@JelteF JelteF added this to the 0.1.0 milestone Sep 17, 2024
@mkaruza mkaruza self-assigned this Sep 17, 2024
@mkaruza
Copy link
Collaborator

mkaruza commented Sep 17, 2024

Yes, imo all index functionality and code should be revisited again probably when i return back to finalize #71 feature.

@JelteF
Copy link
Collaborator Author

JelteF commented Sep 17, 2024

It was working in the past iirc, also at minimum it shouldn't crash the server, but throw a clear error. But preferably it would fall back to sequence scan.

@JelteF
Copy link
Collaborator Author

JelteF commented Oct 3, 2024

As discussed over chat. Our current Postgres index scan logic is incorrect. For 0.1.0 we've decided to revert the feature completely and only support sequential scans on postgres data from duckdb. It's definitely a feature we want, but we're not going to let it block version 0.1.0. We'll probably redesign it for version 0.2.0.

@JelteF JelteF changed the title Index scans are broken Revert index scan functionality Oct 3, 2024
mkaruza added a commit that referenced this issue Oct 3, 2024
Reverting index scan feature as explaind in #183.
Removed include directives that are not needed.
mkaruza added a commit that referenced this issue Oct 3, 2024
Reverting index scan feature as explained in #183. Removed
include directives that are not needed.
mkaruza added a commit that referenced this issue Oct 4, 2024
Reverting index scan feature as explained in #183.
mkaruza added a commit that referenced this issue Oct 4, 2024
Reverting index scan feature as explained in #183.
mkaruza added a commit that referenced this issue Oct 7, 2024
Reverting index scan feature as explained in #183.
mkaruza added a commit that referenced this issue Oct 7, 2024
Reverting index scan feature as explained in #183.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants