Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide on default DuckDB configuration that makes sense for use in postgres #217

Closed
4 tasks
JelteF opened this issue Sep 24, 2024 · 2 comments · Fixed by #338
Closed
4 tasks

Decide on default DuckDB configuration that makes sense for use in postgres #217

JelteF opened this issue Sep 24, 2024 · 2 comments · Fixed by #338
Labels
enhancement New feature or request
Milestone
0.1.0 stability t...

Comments

@JelteF
Copy link
Collaborator

JelteF commented Sep 24, 2024 •
edited
Loading

Related to but separate from #216
@JelteF JelteF added this to the 0.1.0 code complete milestone Sep 30, 2024
@JelteF JelteF added the enhancement New feature or request label Sep 30, 2024
@JelteF JelteF mentioned this issue Oct 7, 2024
Closed
@JelteF
Copy link
Collaborator Author

JelteF commented Oct 16, 2024

Moving this to stability testing

@wuputah
Copy link
Collaborator

wuputah commented Oct 21, 2024 •
edited
Loading

I believe this was the output of the discussion today:

  • 4gb
  • unbounded (default) threads
  • max 1 thread per Postgres scan?

@JelteF JelteF mentioned this issue Oct 22, 2024
Merged
JelteF added a commit that referenced this issue Oct 23, 2024
@JelteF
Update default settings (#338)
c531f72 
Fixes #217 

This changes the defaults for `duckdb.max_memory` and
`duckdb.disabled_filesystems` to the agreed upon settings. While doing
that I found two issues that this also fixes:
1. `duckdb.disabled_filesystems = 'LocalFilesystem'` was basically a way
to make DuckDB execution unusable, due to us doing file system access
when initializing the database/connection. So now we enable the setting
later. Also we now don't call `INSTALL {extension}` during connection
initialization anymore.
2. #316 didn't fix the loading of extensions when
`duckdb.install_extension()` was called. Only for direct inserts to the
`duckdb.extensions` table. That's fixed by not using the low-level
`CatalogTupleInsert`, and instead switching to SPI.
3. Postgres superusers should not be restricted by
`duckdb.disabled_filesystems`, they should be able to do whatever they
want. So now this setting is not actually configured for superusers
anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1.0 stability testing
Development

Successfully merging a pull request may close this issue.

Update default settings duckdb/pg_duckdb
2 participants
@wuputah @JelteF