Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support timestamptz type #228

Closed
JelteF opened this issue Sep 30, 2024 · 1 comment · Fixed by #292
Closed

Support timestamptz type #228

JelteF opened this issue Sep 30, 2024 · 1 comment · Fixed by #292
Assignees
@mkaruza
Labels
enhancement New feature or request
Milestone
0.1.0 code complete

Comments

@JelteF
Copy link
Collaborator

JelteF commented Sep 30, 2024 •
edited
Loading

Generally it's recommended to use the timestamptz type instead of the timestamp type, so we should support this. I think supporting this is probably very simple as it's stored the same on disk as the timestamp type, but it needs a few tests too. If easy, it would be good to support filtering on timestamptz too.
@JelteF JelteF added this to the 0.2.0 milestone Sep 30, 2024
@JelteF JelteF added the enhancement New feature or request label Sep 30, 2024
@wuputah wuputah modified the milestones: 0.2.0, 0.1.0 code complete Oct 4, 2024
@wuputah
Copy link
Collaborator

wuputah commented Oct 4, 2024

This type is very commonly used and to me this seems like an oversight for 0.1; if this is just a few lines of code it would be great to get this done.

@JelteF JelteF mentioned this issue Oct 14, 2024
Open
@mkaruza mkaruza mentioned this issue Oct 15, 2024
Merged
mkaruza added a commit that referenced this issue Oct 15, 2024
@mkaruza @JelteF
Support for TIMESTAMPTZ (#292)
60c0fe9 
Fixes #228

---------

Co-authored-by: Jelte Fennema-Nio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkaruza mkaruza

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1.0 code complete
Development

Successfully merging a pull request may close this issue.

Support for TIMESTAMPTZ duckdb/pg_duckdb
3 participants
@wuputah @JelteF @mkaruza