Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.15.6 - Bring back Aggregation LocalMetadata #8334

Open
niemyjski opened this issue Sep 5, 2024 · 2 comments
Open

8.15.6 - Bring back Aggregation LocalMetadata #8334

niemyjski opened this issue Sep 5, 2024 · 2 comments
Labels
8.x Relates to 8.x client version Category: Enhancement

Comments

@niemyjski
Copy link
Contributor

niemyjski commented Sep 5, 2024

Elastic.Clients.Elasticsearch version: 8.15.6

Elasticsearch version: 8.15.1

.NET runtime version: 8.x

Operating system version: Any

Description of the problem including expected versus actual behavior:

We initially had long discussion about adding support for LocalMetadata and did a PR for this feature here #2320 . LocalMetadata allowed libraries like Foundatio.Parsers / users to pass along extra data locally on the aggregation for things like runtime type, timezone information and more. This allowed us to parse a lucene like (dsl) string and convert it to your agg model, consume the returned aggregation data and convert it to our own dsl / models which supports multiple tech stacks like sql server.

Expected behavior

Bring back LocalMetadata so we can store data on the aggregation for round tripping.

Reference: FoundatioFx/Foundatio.Parsers#84

@flobernd
Copy link
Member

flobernd commented Sep 6, 2024

Hi @niemyjski,

This sounds like a very specialized use-case that might not be required for 99% of the users. Isn't that something that could easily be implemented by the user with a ConditionalWeakTable?

@niemyjski
Copy link
Contributor Author

Yes, great suggestion and I was kind of thinking along those lines of having a lookup table. I'm going to try this approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.x Relates to 8.x client version Category: Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants