Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESQL: Pin now on all data nodes #113709

Closed
nik9000 opened this issue Sep 27, 2024 · 6 comments
Closed

ESQL: Pin now on all data nodes #113709

nik9000 opened this issue Sep 27, 2024 · 6 comments
Assignees
Labels
:Analytics/ES|QL AKA ESQL >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@nik9000
Copy link
Member

nik9000 commented Sep 27, 2024

Description

ESQL currently uses system.currentTimeMillis for the query start time but it really should pin that at query start. See: https://github.com/elastic/elasticsearch/blob/main/x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/session/Configuration.java#L163

@nik9000 nik9000 added :Analytics/ES|QL AKA ESQL >enhancement needs:triage Requires assignment of a team area label labels Sep 27, 2024
@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) and removed needs:triage Requires assignment of a team area label labels Sep 27, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@luigidellaquila
Copy link
Contributor

We already have a "now" in the configuration, I guess we can use it right away

@luigidellaquila luigidellaquila self-assigned this Sep 30, 2024
@nik9000
Copy link
Member Author

nik9000 commented Sep 30, 2024

We already have a "now" in the configuration, I guess we can use it right away

Oh oops. I guess what I really mean is absoluteStartedTimeInMillis - but to be honest those should probably be the same. I'm not sure why our now is Zoned. But that's a thing for another day.

@luigidellaquila
Copy link
Contributor

Sorry, my fault, too many StartedTime things in there...
I think the Zoned is QL legacy code.
I have no idea of why absoluteStartedTimeInMillis and getQueryStartTimeNanos are different (apart from the precision), but now has nanosecond precision as far as I can see, and both queryStartTimeNanos and now are always instantiated at the same time, so I agree with you, they could be the same thing.

@bpintea
Copy link
Contributor

bpintea commented Oct 13, 2024

@luigidellaquila should this be closed after #113777?

@luigidellaquila
Copy link
Contributor

I think so, thanks @bpintea, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Development

No branches or pull requests

4 participants