Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] SimpleNetty4TransportTests testWatchdogLogging failing #113734

Closed
elasticsearchmachine opened this issue Sep 28, 2024 · 2 comments · Fixed by #113758
Closed

[CI] SimpleNetty4TransportTests testWatchdogLogging failing #113734

elasticsearchmachine opened this issue Sep 28, 2024 · 2 comments · Fixed by #113758
Assignees
@DaveCTurner
Labels
:Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. low-risk An open issue or test failure that is a low risk to future releases Team:Distributed Meta label for distributed team (obsolete) >test-failure Triaged test failures from CI

Comments

@elasticsearchmachine
Copy link
Collaborator

Build Scans:

Reproduction Line:

./gradlew ":modules:transport-netty4:pooledTest" --tests "org.elasticsearch.transport.netty4.SimpleNetty4TransportTests.testWatchdogLogging" -Dtests.seed=4D2A44296E66981E -Dtests.locale=mfe-MU -Dtests.timezone=Europe/Vienna -Druntime.java=22

Applicable branches:
main

Reproduces locally?:
N/A

Failure History:
See dashboard

Failure Message:

java.lang.AssertionError: expected to see stuck threads logging but did not
Expected: <0L>
     but: was <1L>

Issue Reasons:

  • [main] 2 failures in test testWatchdogLogging (0.3% fail rate in 677 executions)
  • [main] 2 failures in pipeline elasticsearch-periodic-platform-support (33.3% fail rate in 6 executions)

Note:
This issue was created using new test triage automation. Please report issues or feedback to es-delivery.
@elasticsearchmachine elasticsearchmachine added :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >test-failure Triaged test failures from CI Team:Distributed Meta label for distributed team (obsolete) needs:risk Requires assignment of a risk label (low, medium, blocker) labels Sep 28, 2024
@elasticsearchmachine
Copy link
Collaborator Author

Pinging @elastic/es-distributed (Team:Distributed)

@DaveCTurner DaveCTurner self-assigned this Sep 28, 2024
@DaveCTurner
Copy link
Contributor

The actual message was this:

the following threads are active but did not make progress in the preceding [5s]: [elasticsearch[TS_A][transport_worker][T#13], elasticsearch[TS_B][transport_worker][T#15]]

Seems ok, just need to relax the assertion.

@DaveCTurner DaveCTurner added low-risk An open issue or test failure that is a low risk to future releases and removed needs:risk Requires assignment of a risk label (low, medium, blocker) labels Sep 28, 2024
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this issue Sep 30, 2024
@DaveCTurner
Fix testWatchdogLogging
c5ed861 
It's possible that the expected thread isn't the only thread that made
no progress since the last check, so this commit generalizes the
assertion to allow for other threads to be mentioned here too.

Closes elastic#113734
@DaveCTurner DaveCTurner mentioned this issue Sep 30, 2024
Merged
DaveCTurner added a commit that referenced this issue Oct 1, 2024
@DaveCTurner
Fix testWatchdogLogging (#113758)
fe5940e 
It's possible that the expected thread isn't the only thread that made
no progress since the last check, so this commit generalizes the
assertion to allow for other threads to be mentioned here too.

Closes #113734
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this issue Oct 1, 2024
@DaveCTurner
Fix testWatchdogLogging (elastic#113758)
6082047 
It's possible that the expected thread isn't the only thread that made
no progress since the last check, so this commit generalizes the
assertion to allow for other threads to be mentioned here too.

Closes elastic#113734
elasticsearchmachine pushed a commit that referenced this issue Oct 1, 2024
@DaveCTurner
Fix testWatchdogLogging (#113758) (#113830)
b835fcd 
It's possible that the expected thread isn't the only thread that made
no progress since the last check, so this commit generalizes the
assertion to allow for other threads to be mentioned here too.

Closes #113734
matthewabbott pushed a commit to matthewabbott/elasticsearch that referenced this issue Oct 4, 2024
@DaveCTurner @matthewabbott
Fix testWatchdogLogging (elastic#113758)
4af4a5e 
It's possible that the expected thread isn't the only thread that made
no progress since the last check, so this commit generalizes the
assertion to allow for other threads to be mentioned here too.

Closes elastic#113734
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DaveCTurner DaveCTurner

Labels
:Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. low-risk An open issue or test failure that is a low risk to future releases Team:Distributed Meta label for distributed team (obsolete) >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix testWatchdogLogging DaveCTurner/elasticsearch
2 participants
@DaveCTurner @elasticsearchmachine