Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Screenshots couldnt be taken error #2150

Open
2 tasks done
definetelynotarobot opened this issue Sep 20, 2024 · 7 comments
Open
2 tasks done

[Bug]: Screenshots couldnt be taken error #2150

definetelynotarobot opened this issue Sep 20, 2024 · 7 comments
Labels
bug Something isn't working stale

Comments

@definetelynotarobot
Copy link

Describe the bug

image
"there was an error making the screenshots"

Reproduction Steps

run the app and observe that the error "something went wrong with screenshots" exists

Expected behavior

no error with screenshots and continue making the video.

Screenshots

image
image
image

System Information

Operating System : [e.g. Windows 10]
Python version : [e.g. Python 3.10]
App version / Branch : [e.g. latest, V3.3, master, develop]

Checklist

  • I have searched the open issues for duplicates.
  • I have shown the entire traceback, if possible.

Additional Context

No response

@definetelynotarobot definetelynotarobot added the bug Something isn't working label Sep 20, 2024
@Roostydoo2
Copy link

#2129

@MohaMBS
Copy link

MohaMBS commented Sep 22, 2024

I'm working on it to make a quick fix, the problem is due to reddit changes...

@Motzumoto
Copy link

Motzumoto commented Sep 22, 2024

#2129

Mentioning this other issue is clearly not needed as this is an error on prod. this was not fixed.

Also to add onto this, I'm also experiencing this issue.

Traceback (most recent call last):
  File "/home/lain/RedditVideoMakerBot/main.py", line 131, in <module>
    raise err
  File "/home/lain/RedditVideoMakerBot/main.py", line 113, in <module>
    run_many(config["settings"]["times_to_run"])
  File "/home/lain/RedditVideoMakerBot/main.py", line 68, in run_many
    main()
  File "/home/lain/RedditVideoMakerBot/main.py", line 52, in main
    get_screenshots_of_reddit_posts(reddit_object, number_of_comments)
  File "/home/lain/RedditVideoMakerBot/video_creation/screenshot_downloader.py", line 203, in get_screenshots_of_reddit_posts
    raise e
  File "/home/lain/RedditVideoMakerBot/video_creation/screenshot_downloader.py", line 180, in get_screenshots_of_reddit_posts
    location = page.locator('[data-test-id="post-content"]').bounding_box()
  File "/home/lain/RedditVideoMakerBot/.venv/lib/python3.10/site-packages/playwright/sync_api/_generated.py", line 14782, in bounding_box
    self._sync(self._impl_obj.bounding_box(timeout=timeout))
  File "/home/lain/RedditVideoMakerBot/.venv/lib/python3.10/site-packages/playwright/_impl/_sync_base.py", line 115, in _sync
    return task.result()
  File "/home/lain/RedditVideoMakerBot/.venv/lib/python3.10/site-packages/playwright/_impl/_locator.py", line 127, in bounding_box
    return await self._with_element(
  File "/home/lain/RedditVideoMakerBot/.venv/lib/python3.10/site-packages/playwright/_impl/_locator.py", line 108, in _with_element
    handle = await self.element_handle(timeout=timeout)
  File "/home/lain/RedditVideoMakerBot/.venv/lib/python3.10/site-packages/playwright/_impl/_locator.py", line 311, in element_handle
    handle = await self._frame.wait_for_selector(
  File "/home/lain/RedditVideoMakerBot/.venv/lib/python3.10/site-packages/playwright/_impl/_frame.py", line 323, in wait_for_selector
    await self._channel.send("waitForSelector", locals_to_params(locals()))
  File "/home/lain/RedditVideoMakerBot/.venv/lib/python3.10/site-packages/playwright/_impl/_connection.py", line 59, in send
    return await self._connection.wrap_api_call(
  File "/home/lain/RedditVideoMakerBot/.venv/lib/python3.10/site-packages/playwright/_impl/_connection.py", line 514, in wrap_api_call
    raise rewrite_error(error, f"{parsed_st['apiName']}: {error}") from None
playwright._impl._errors.TimeoutError: Locator.bounding_box: Timeout 30000ms exceeded.
Call log:
waiting for locator("[data-test-id=\"post-content\"]")

@JasonLovesDoggo
Copy link
Collaborator

I'm working on it to make a quick fix, the problem is due to reddit changes...

feel free to ping me either on discord or in a PR once you've made one

@MohaMBS
Copy link

MohaMBS commented Sep 23, 2024

I'm working on it to make a quick fix, the problem is due to reddit changes...

feel free to ping me either on discord or in a PR once you've made one

Today I will deploy the changes (it will not be a total fix, but a temporary one)

@MohaMBS
Copy link

MohaMBS commented Sep 23, 2024

Check my PR that solves this bug: #2151
I hope it will be helpful

Copy link
Contributor

github-actions bot commented Oct 1, 2024

This issue is stale because it has been open 7 days with no activity. Remove stale label or comment, or this will be closed in 10 days.

@github-actions github-actions bot added the stale label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

5 participants