-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Context support #19
Comments
I'd like to see how the API could look like. |
For client it would involve duplicating As for relation to timeouts, perhaps we could have context-less functions create such context with some timeout value (e.g. 5 mins)? That would be convenient for me since maddy interfaces already have context.Context all over the place :) |
On a second thought, gluing together net.Conn and context.Context is a tricky task so it is probably better to just implement command timeouts like it is done for the server. |
+1 for the context, especially when you need to print debug logs per request and log the request ID. This would also require a rewriting of the Debug functionality. |
Adding context support would be nice for tracing and cancellation.
Thanks for this library!
The text was updated successfully, but these errors were encountered: