Icon Support

[MisterJames]

We had talked about plugging in the icons so I dug up a class I made before Christmas with the icon names. The more I look at it, the more I think we should do a separate package for the rendering bits, and leave the nav base implementation and rendering interfaces in the NavigationRoutes project (which...I think we agreed we're going to rename to NavigationManager).

• Create helper to render prepend html/control group
• Create eval method of some kind to identify known properties and map to icons
• Break out project? <= need to discuss
• Update samples, scaffolders

[erichexter]

yes to rename the project, starting with the nuget package id.
you want to put the icon stuff in a different project? Since it is
bootstrap specific it seems like it should go in there.

[MisterJames]

By "there" I'm figuring you're meaning the Twitter.Bootstrap.Mvc project...so, it likely makes sense to leave the interfaces for rendering here as well, and put the Bootstrap implementation of rendering in Twitter.Bootstrap.Mvc.

[erichexter]

Yes. Sorry about the vauge pronouns.
On Feb 23, 2013 4:49 PM, "James Chambers" [email protected] wrote:

By "there" I'm figuring you're meaning the Twitter.Bootstrap.Mvc
project...so, it likely makes sense to leave the interfaces for rendering
here as well, and put the Bootstrap implementation of rendering in
Twitter.Bootstrap.Mvc.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/4#issuecomment-13999623.

[MisterJames]

:)

[MisterJames]

Okay...so, some simple interfaces here, and we'll do the actual Bootstrap implementation in the TBM project. I like that. That will mean moving the icons...no biggie...and the rendering helpers. I like that though, cleaner. I'll be able to pick things back up on Monday evening, checking out for the weekend.

[serra]

Please note that there already is a similar icon helper class in TBM, in the htmlhelpers package.

[MisterJames]

Ah, cool, thanks @serra. The helper there will be a good foundation for that, too, but I do prefer the c# style casing. Any objections to that?

[serra]

No objections to that - considering TBM is a bootstrapper, I don't necessarily mind breaking backwards compatibility. As long as we don't have multiple icon support implementations, I'm happy.