Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 This interaction failed - Volume Control Past Maximum #1628

Open
SugarD-x opened this issue May 30, 2024 · 0 comments · May be fixed by #1629
Open

🐛 This interaction failed - Volume Control Past Maximum #1628

SugarD-x opened this issue May 30, 2024 · 0 comments · May be fixed by #1629

Comments

@SugarD-x
Copy link

Describe the bug
When actively playing a video, increasing the volume via reaction button when already at 100% causes a This interaction failed error to appear between the reaction buttons. This affects the latest repository version of the bot.

How To Reproduce
Steps to reproduce the behavior:

  1. Play a song.
  2. While the volume is at 100%, press the volume up reaction button.
  3. Error appears.

Expected behavior
An error message should not appear. A message stating that the volume is already at 100% would likely be a better notification sent via user-only interaction message.

Environment (add if possible)

  • Node.js version: 22.2.0
  • NPM version: 10.8.0

Additional information & screenshots
I have not tested this with the volume down button when already at 0%, but this likely already exists. I am also not sure if starting with lower default volumes and increasing/decreasing to these levels would trigger it or not. (I'd assume so). My default volume via my config.json is already at 100%.
krakenftw added a commit to krakenftw/evobot that referenced this issue May 31, 2024
@krakenftw
feat: disabled volume buttons when volume goes to 100 or 0
1f3e84f 
Added checks while changing volume, on 100 volume the volume up button is disabled and same for
volume 0. Improves UX and removes the interaction failed as showed in eritislami#1628

fix eritislami#1628
@krakenftw krakenftw linked a pull request May 31, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: disabled volume buttons when volume goes to 100 or 0 krakenftw/evobot
1 participant
@SugarD-x