-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Real address #21
Comments
Yes. In fact, most systems that do provide the address are not doing it correctly. I've been thinking for a while about running a reverse geocoding lookup on all stations for all systems and not just the ones that include it on the original feed, but that poses the following question: Is there a need for the 'address' field at all? I can't think of an scenario where this field would come in handy, but I have no problem adding it if that does make the API more useful. |
I think information must be more accurate than original services. Real address could be used to find a location without use of a map as in here: http://ecobicidx-20724.onmodulus.net/#/test |
Agreed. I will add an Station.lookupAddress() method in pybikes, and from there it should be possible to run that on a batch server-side (on the sync step) so it is reflected into the API too. |
Addresses for some networks are wrong, for instance in ecobici 251 GOETHE-DARWIN, should be Goethe 17, Anzures, Miguel Hidalgo, 11590 Mexico City, Federal District, Mexico. I know that came from the original source but using reverse geocoding api from google it could be possible to catch the real addresses as in this example: http://ecobicidx-20724.onmodulus.net/stations/all
The text was updated successfully, but these errors were encountered: