Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule proposal: disallow disabling of errors #184

Open
20manas opened this issue Feb 17, 2024 · 0 comments
Open

Rule proposal: disallow disabling of errors #184

20manas opened this issue Feb 17, 2024 · 0 comments

Comments

@20manas
Copy link

20manas commented Feb 17, 2024

This rule can be optional. It will prevent disabling of all eslint rules which are errors. So only warnings can be disabled.

Reasoning

In a project, if some rules are set as errors, the intention is that those errors should always be handled and the situations which cause those errors should never occur. However, if somes rules are set as warnings, they can be ignored (and hence disabled). Thus it makes sense that only warnings should be allowed to be disabled.

This can also speed up code reviews as a reviewer can be certain that no crucial rule has been disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant