Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(no-process-env): Allow users to exclude specific variables #345

Merged
merged 4 commits into from
Oct 9, 2024
Merged

feat(no-process-env): Allow users to exclude specific variables #345

merged 4 commits into from
Oct 9, 2024

Conversation

scagood
Copy link

@scagood scagood commented Sep 25, 2024 •
edited
Loading

This allows users to exclude specific variables from no-process-env using the allowedVariables string array.

@scagood scagood linked an issue Sep 25, 2024 that may be closed by this pull request
Change Request: Add option to allow NODE_ENV in n/no-process-env #283
Closed
1 task
@scagood scagood requested review from a team and aladdin-add September 25, 2024 21:19
aladdin-add
aladdin-add approved these changes Oct 9, 2024
View reviewed changes
Copy link

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add merged commit b16a475 into eslint-community:master Oct 9, 2024
23 checks passed
@github-actions github-actions bot mentioned this pull request Oct 9, 2024
Merged
@alecmev
Copy link

alecmev commented Oct 9, 2024

Thank you! 👍

@scagood scagood deleted the issue-283 branch October 9, 2024 09:31
@snyk-io snyk-io bot mentioned this pull request Oct 31, 2024
Open
This was referenced Nov 4, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aladdin-add aladdin-add aladdin-add approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change Request: Add option to allow NODE_ENV in n/no-process-env
3 participants
@scagood @alecmev @aladdin-add