Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async PARL_IO is using the wrong DMA future #1841

Closed
bjoernQ opened this issue Jul 22, 2024 · 0 comments · Fixed by #1851
Closed

Async PARL_IO is using the wrong DMA future #1841

bjoernQ opened this issue Jul 22, 2024 · 0 comments · Fixed by #1851
Assignees
@bjoernQ
Labels
bug Something isn't working
Milestone
0.20.0

Comments

@bjoernQ
Copy link
Contributor

bjoernQ commented Jul 22, 2024

See #1835 (comment)

TL;DR change

esp-hal/esp-hal/src/parl_io.rs

Line 1761 in 1424f2a

let future = DmaRxDoneChFuture::new(&mut self.rx_channel);
to use DmaRxFuture instead
@bjoernQ bjoernQ added the bug Something isn't working label Jul 22, 2024
@bjoernQ bjoernQ mentioned this issue Jul 22, 2024
Merged
5 tasks
@MabezDev MabezDev added this to the 0.20.0 milestone Jul 22, 2024
@bjoernQ bjoernQ self-assigned this Jul 24, 2024
@bjoernQ bjoernQ mentioned this issue Jul 24, 2024
Merged
5 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjoernQ bjoernQ

Labels
bug Something isn't working
Projects
esp-rs
Archived in project
Milestone
0.20.0
Development

Successfully merging a pull request may close this issue.

Fix async PARL_IO RX bjoernQ/esp-hal
2 participants
@bjoernQ @MabezDev