Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIL tests don't clean up after themselves #1992

Closed
bugadani opened this issue Aug 23, 2024 · 0 comments · Fixed by #1993
Closed

HIL tests don't clean up after themselves #1992

bugadani opened this issue Aug 23, 2024 · 0 comments · Fixed by #1993
Labels
bug Something isn't working CI Continuous integration/deployment tests Unit, Integration, or Hardware-in-Loop Testing

Comments

@bugadani
Copy link
Contributor

https://github.com/esp-rs/esp-hal/actions/runs/10530580292/job/29180988995?pr=1990 was a failure, because even though S2 got disabled, the HIL tester still contained, and then ran the test binaries for it. We should probably remove test files before we start downloading the binaries.
@bugadani bugadani added bug Something isn't working CI Continuous integration/deployment labels Aug 23, 2024
@bugadani bugadani mentioned this issue Aug 23, 2024
Merged
@jessebraham jessebraham added the tests Unit, Integration, or Hardware-in-Loop Testing label Aug 25, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working CI Continuous integration/deployment tests Unit, Integration, or Hardware-in-Loop Testing
Projects
esp-rs
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

HIL: Remove files after test bugadani/esp-hal
2 participants
@bugadani @jessebraham