Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qspi_flash example broken #2005

Closed
bjoernQ opened this issue Aug 27, 2024 · 1 comment
Closed

qspi_flash example broken #2005

bjoernQ opened this issue Aug 27, 2024 · 1 comment
Assignees
Labels
bug Something isn't working peripheral:spi SPI peripheral status:needs-attention This should be prioritized
Milestone

Comments

@bjoernQ
Copy link
Contributor

bjoernQ commented Aug 27, 2024

Only tested on ESP32-C6 - but most probably the problem is present for other chips, too.

54ee3641309d3530226e71277102038a1cda9281 is the first bad commit
commit 54ee3641309d3530226e71277102038a1cda9281
Author: Juraj Sadel <[email protected]>
Date:   Wed Aug 7 15:23:49 2024 +0200

    ESP32(SPI): Disable the write side when reading is being done in DMA … (#1894)

    * ESP32(SPI): Disable the write side when reading is being done in DMA mode

    * disable and re-enable MISO and MOSI in write and transfer methods

    * changelog

 esp-hal/CHANGELOG.md      |  1 +
 esp-hal/src/spi/master.rs | 15 +++++++++++++++
 2 files changed, 16 insertions(+)

@bjoernQ bjoernQ added peripheral:spi SPI peripheral status:needs-attention This should be prioritized labels Aug 27, 2024
@MabezDev MabezDev added the bug Something isn't working label Aug 27, 2024
@MabezDev MabezDev added this to the 0.20.0 milestone Aug 27, 2024
@esp-rs esp-rs deleted a comment Aug 27, 2024
@bjoernQ
Copy link
Contributor Author

bjoernQ commented Aug 28, 2024

Closed via #2013

@bjoernQ bjoernQ closed this as completed Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working peripheral:spi SPI peripheral status:needs-attention This should be prioritized
Projects
Archived in project
Development

No branches or pull requests

2 participants