Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp-wifi: RFC Remove embedded-svc #2166

Closed
bjoernQ opened this issue Sep 16, 2024 · 1 comment · Fixed by #2235
Closed

esp-wifi: RFC Remove embedded-svc #2166

bjoernQ opened this issue Sep 16, 2024 · 1 comment · Fixed by #2235
Assignees
Labels
package:esp-wifi Issues related to the esp-wifi package
Milestone

Comments

@bjoernQ
Copy link
Contributor

bjoernQ commented Sep 16, 2024

We optionally implement the wifi trait (and accompanying types) from embedded-svc - is that useful to someone or is it just unnecessary burden?

Is anyone actually using it (for non-esoteric reasons)?

@SergioGasquez SergioGasquez added the package:esp-wifi Issues related to the esp-wifi package label Sep 16, 2024
@MabezDev
Copy link
Member

From our meeting, we decided to remove support for now. We can always re-add it, but right now we don't see the value as not many crates (any?) build on top of these traits.

@MabezDev MabezDev added this to the 0.21.0 milestone Sep 25, 2024
@MabezDev MabezDev assigned SergioGasquez and unassigned bjoernQ Sep 25, 2024
@SergioGasquez SergioGasquez linked a pull request Sep 26, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:esp-wifi Issues related to the esp-wifi package
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants