Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add generic grant layout component #228

Open
nhsz opened this issue Aug 29, 2022 · 2 comments
Open

refactor: add generic grant layout component #228

nhsz opened this issue Aug 29, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@nhsz
Copy link
Member

nhsz commented Aug 29, 2022

Layout components (like ApplicantsLayout, AboutLayout) should solve the layout we need for each page (including mobile), with the corresponding margins and paddings. Besides the fixed layouts mentioned above, we need a genericGrantsLayout for the recurring grants pages (e.g.: Devcon, Academic Grants, Merge Data Challenge), etc and refactor the other components to make the code cleaner and easier to follow and maintain in the future.

@nhsz nhsz added the enhancement New feature or request label Aug 29, 2022
@samajammin
Copy link
Member

Noting this came up in discussion of #227

This should have been solved at the MergeDataChallengeLayout level, not in the apply page.

@ap501boii
Copy link

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants