New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add better description/tooltip to "valid" fields #69

Open

Savid opened this issue Jan 28, 2024 · 0 comments

Member

Savid commented Jan 28, 2024

Validity in the fork choice payload has different values and may not specifically mean the block is "invalid".

Here are prysm validity for example https://github.com/prysmaticlabs/prysm/blob/develop/consensus-types/forkchoice/types.go#L16-L27

At the moment a slot will show yellow if its validity is optimistic and red when its anything other than valid or optimistic.

Might be good to add descriptions everywhere for "valid"/"validity" so its easy and quickly to understand what this field is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment