Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch-configlet: DRY/sync with version in configlet repo #103

Open
ee7 opened this issue Jan 5, 2023 · 2 comments
Open

fetch-configlet: DRY/sync with version in configlet repo #103

ee7 opened this issue Jan 5, 2023 · 2 comments

Comments

@ee7
Copy link
Member

ee7 commented Jan 5, 2023

Or reach feature parity with it.

For the fetch-configlet script in this repo, which is designed to be used only in the GitHub Actions environment, we could also consider a gh-only implementation like:

name='configlet.tar.gz'
gh -R exercism/configlet release download --output "${name}" \
  --pattern 'configlet_*_linux_x86-64.tar.gz'
tar xzf "${name}" -C bin/
rm "${name}"
ee7 added a commit to ee7/exercism-github-actions that referenced this issue Jan 6, 2023
@SaschaMann
Copy link
Contributor

The gh implementation would avoid the token issues, seems like a good idea to change to that.

@ee7
Copy link
Member Author

ee7 commented Jan 6, 2023

Yeah. We have to pass in a token either way, but gh always makes authenticated requests. So that's more robust, at least in the sense that it fails noisily if the token handling is bad.

I've created #107, which uses the script from the top post in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants