Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify secrets #65

Open
SaschaMann opened this issue May 3, 2022 · 10 comments
Open

Simplify secrets #65

SaschaMann opened this issue May 3, 2022 · 10 comments
Assignees
@hsadia538
Labels
x:action/improve Improve existing functionality/content x:knowledge/none No existing Exercism knowledge required x:size/tiny Tiny amount of work x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows) x:type/coding Write code that is not student-facing content (e.g. test-runners, generators, but not exercises)

Comments

@SaschaMann
Copy link
Contributor

https://github.blog/changelog/2022-05-03-github-actions-simplify-using-secrets-with-reusable-workflows/
@SaschaMann SaschaMann added x:action/improve Improve existing functionality/content x:knowledge/none No existing Exercism knowledge required x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows) x:type/coding Write code that is not student-facing content (e.g. test-runners, generators, but not exercises) x:size/tiny Tiny amount of work labels May 3, 2022
@ahtashamjaved

This comment was marked as off-topic.

Sign in to view
@hsadia538
Copy link

@SaschaMann I would Like to work on this, can you assign me ?

@hsadia538
Copy link

@SaschaMann Initially I did not have much understanding of GitHub workflows and everything but after reading on it now I get what the article says
Just putting here for confirmation: In all the caller flows, I have to add secrets: inherit right?

@SaschaMann
Copy link
Contributor Author

@ErikSchierboom might be able to help you out, I'm not really active in this project anymore

@hsadia538
Copy link

@ErikSchierboom can you verify?

@ErikSchierboom
Copy link
Member

That is correct. I think there's just one location where this can be applied: https://github.com/exercism/org-wide-files/blob/main/tooling-files/.github/workflows/deploy.yml

We'd need to rename some settings for it to work at https://github.com/exercism/snippet-extractor/blob/main/.github/workflows/deploy.yml

@hsadia538
Copy link

just for clarificationL: why do we need to rename settings at https://github.com/exercism/snippet-extractor/blob/main/.github/workflows/deploy.yml

@ErikSchierboom
Copy link
Member

Because they use different names:

AWS_ECR_ACCESS_KEY_ID: ${{secrets.AWS_LAMBDA_ACCESS_KEY_ID}}

@artfuldev
Copy link

Hi, is this still useful and yet to be picked up? I have some time I can contribute to this issue with.

@ErikSchierboom
Copy link
Member

I'm not entirely sure we want this. I sort of like the explicitness of the current setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsadia538 hsadia538

Labels
x:action/improve Improve existing functionality/content x:knowledge/none No existing Exercism knowledge required x:size/tiny Tiny amount of work x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows) x:type/coding Write code that is not student-facing content (e.g. test-runners, generators, but not exercises)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ErikSchierboom @artfuldev @SaschaMann @hsadia538 @ahtashamjaved