Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to version 3 spec #37

Open
ErikSchierboom opened this issue Aug 18, 2021 · 6 comments · May be fixed by #100
Open

Upgrade to version 3 spec #37

ErikSchierboom opened this issue Aug 18, 2021 · 6 comments · May be fixed by #100
Labels
x:action/improve Improve existing functionality/content x:knowledge/advanced Comprehensive Exercism knowledge required x:module/test-runner Work on Test Runners x:size/large Large amount of work x:type/coding Write code that is not student-facing content (e.g. test-runners, generators, but not exercises)

Comments

@ErikSchierboom
Copy link
Member

ErikSchierboom commented Aug 18, 2021

If possible, this test runner should be updated to version 3 of the test runner interface specification. In version 3, one additional feature is enabled: the ability to link individual tests to tasks. This allows the website to show which tests belong to which tasks.

The way tests are linked to tasks is via an (optional) task_id field (see the specification), which is an integer that matches the number of the task as defined in the exercise's instructions.md file (note: the instructions start at index 1).

This is an example of a test in the results.json file:

{
  "name": "Expected oven time in minutes",
  "status": "pass",
  "task_id": 1,
  "test_code": "Assert.Equal(40, Lasagna.ExpectedMinutesInOven());"
}

You are completely free in how to implement this. Some options are:

  1. Add metadata to a test that the test runner can then discover while running the tests (e.g. an attribute or annotation)
  2. Define a test name/task id mapping (e.g. in the exercise's .meta/config.json file)
  3. Any other option you can think of...

Let me know if there are any questions.

@ErikSchierboom ErikSchierboom added x:action/improve Improve existing functionality/content x:knowledge/advanced Comprehensive Exercism knowledge required x:module/test-runner Work on Test Runners x:size/large Large amount of work x:type/coding Write code that is not student-facing content (e.g. test-runners, generators, but not exercises) labels Aug 18, 2021
@theomelo
Copy link

theomelo commented Nov 6, 2022

I want to work on this one 🤚

@kotp
Copy link
Member

kotp commented Nov 7, 2022

I want to work on this one raised_back_of_hand

Absolutely!

Link your PR here, or any ongoing questions can be asked here as well.

@kotp
Copy link
Member

kotp commented Mar 11, 2023

@theomelo I hope the last few months have treated you well. Any news on this, or should I unassign and make it available to someone else to pick up?

Hunk13 added a commit to Hunk13/ruby-test-runner that referenced this issue Jun 27, 2023
@Hunk13 Hunk13 linked a pull request Jun 27, 2023 that will close this issue
Hunk13 added a commit to Hunk13/ruby-test-runner that referenced this issue Jul 4, 2023
@petrenkorf
Copy link

@kotp Any news on this? I'm looking for some task for my first PR, is this a good one?

@kotp
Copy link
Member

kotp commented Oct 21, 2023

Look at #100 and the comment there, for whatever reason I have not seen the forum post that @iHiD requested. But I think it is work that is approved since @ErikSchierboom created the issue, it just has not been followed up on by @Hunk13 as of yet.

@theomelo
Copy link

theomelo commented Feb 1, 2024

@kotp, my apologies for disappearing. It's been a rollercoaster ever since, but I appreciate @Hunk13 taking this on. I'll unassign myself from this issue.

@theomelo theomelo removed their assignment Feb 1, 2024
Hunk13 added a commit to Hunk13/ruby-test-runner that referenced this issue Feb 14, 2024
Hunk13 added a commit to Hunk13/ruby-test-runner that referenced this issue Apr 9, 2024
Hunk13 added a commit to Hunk13/ruby-test-runner that referenced this issue Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/improve Improve existing functionality/content x:knowledge/advanced Comprehensive Exercism knowledge required x:module/test-runner Work on Test Runners x:size/large Large amount of work x:type/coding Write code that is not student-facing content (e.g. test-runners, generators, but not exercises)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants